Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Added docs about the new ILM kibana-reporting policy #108018

Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Aug 10, 2021

Summary

After merging #104303, this contribution adds user facing documentation calling out the new kibana-reporting policy.

Screenshot 2021-08-10 at 12 04 31

To reviewers

I recommend reviewing this PR with whitespace changes hidden.

@jloleysens jloleysens added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a non-blocking suggestion you can disregard if wanted.

I'd like to get someone from @elastic/kibana-docs to review before merging. I'm not super familiar with Kibana's reporting feature.

docs/user/reporting/index.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With James' edits, LGTM.

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jloleysens jloleysens merged commit 46e0f0b into elastic:master Aug 11, 2021
@jloleysens jloleysens deleted the reporting/docs-for-the-new-ilm-policy branch August 11, 2021 10:43
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2021
…lastic#108018)

* first iteration of ilm policy copy - in a callout

* apply James' suggested change

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 11, 2021
…108018) (#108172)

* first iteration of ilm policy copy - in a callout

* apply James' suggested change

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@kunisen
Copy link
Contributor

kunisen commented Apr 11, 2024

Hi @jloleysens sorry for asking in a very old ticket.

We have a quick question: Can users tweak the ILM policy and add a delete phase by themselves?
By reading the statement, we had the feeling that users can tweak this based on their needs. We want to make sure if this is correct.

Thanks!
cc @jasonyoum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants